GH-48093: [C++][FlightRPC] Replace boost::algorithm with alternatives#48688
GH-48093: [C++][FlightRPC] Replace boost::algorithm with alternatives#48688lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
|
|
|
R test failure should not be related to this .. I created an issue and started working on it to make it less flaky #48690 |
|
I'm going to leave the ticket open since I see there are other uses of boost::algorithm in the ODBC code |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 37c40fb. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Replaces
boost::algorithm::joinwith Arrow's internalarrow::internal::JoinStringsto remove the boost dependency. Both functions have equivalent behavior: they join a vector of strings with a delimiter.What changes are included in this PR?
Replaced
boost::algorithm::join(*create_params, ",")witharrow::internal::JoinStrings(*create_params, ",")(line 112) atcpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_statement_get_type_info.cc.From
boost/algorithm/string/join.hpp:From
cpp/src/arrow/util/string.cc:126-148:Are these changes tested?
Yes. Existing test cases should verify the change.
Are there any user-facing changes?
No.